fixed pathencode to support '(' ')' characters

benoitc / hackney

simple HTTP client in Erlang

Other

1.34k stars 427 forks source link

fixed pathencode to support '(' ')' characters #551

Closed idod closed 5 years ago

idod commented 5 years ago

Related to #550

After checking the RFC section 2.2, Reserved Characters, sub-delims, it seems that url path with '(' ')' characters is valid and should not be encoded. I would like to do the same for the other characters as well, and do a small refactor that will reflect the RFC. What do you think?

Cheers

benoitc commented 5 years ago

isn't your PR handling the missing reserved characters already? What other changes are you thinking? Otherwise I think that PR is OK for me.

benoitc commented 5 years ago

similar to #251

benoitc commented 5 years ago

@idod thanks!