benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

pool cannot be disable with use_default_pool: false #580

Closed madawei2699 closed 5 years ago

madawei2699 commented 5 years ago

When I use a rotate proxy ip, I want to disable connect pool with use_default_pool to false, it does not work, but it works with pool: false.

iex(instaghub@127.0.0.1)45> HTTPoison.get!("https://api.ipify.org", [], [{:proxy, proxy}, hackney: [pool: false]])
%HTTPoison.Response{
  body: "86.14.124.144",
  headers: [
    {"Server", "Cowboy"},
    {"Connection", "keep-alive"},
    {"Content-Type", "text/plain"},
    {"Vary", "Origin"},
    {"Date", "Mon, 24 Jun 2019 22:33:05 GMT"},
    {"Content-Length", "13"},
    {"Via", "1.1 vegur"}
  ],
  request: %HTTPoison.Request{
    body: "",
    headers: [],
    method: :get,
    options: [proxy: "83.149.70.159:13012", hackney: [pool: false]],
    params: %{},
    url: "https://api.ipify.org"
  },
  request_url: "https://api.ipify.org",
  status_code: 200
}
iex(instaghub@127.0.0.1)46> HTTPoison.get!("https://api.ipify.org", [], [{:proxy, proxy}, hackney: [pool: false]])
%HTTPoison.Response{
  body: "125.205.31.88",
  headers: [
    {"Server", "Cowboy"},
    {"Connection", "keep-alive"},
    {"Content-Type", "text/plain"},
    {"Vary", "Origin"},
    {"Date", "Mon, 24 Jun 2019 22:33:12 GMT"},
    {"Content-Length", "13"},
    {"Via", "1.1 vegur"}
  ],
  request: %HTTPoison.Request{
    body: "",
    headers: [],
    method: :get,
    options: [proxy: "83.149.70.159:13012", hackney: [pool: false]],
    params: %{},
    url: "https://api.ipify.org"
  },
  request_url: "https://api.ipify.org",
  status_code: 200
}
benoitc commented 5 years ago

fixed. Thanks!