benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

Failed tests without any commits on a forked repository #584

Closed techno-tanoC closed 4 years ago

techno-tanoC commented 5 years ago

I forked the repository, and run tests on Travis CI.

Although I didn't commit, some tests failed.

I watched logs and noticed that CI fetches the ranch version 2.0.0-rc.1. (the original tests fetched the ranch version 1.7.1)

https://travis-ci.org/techno-tanoC/hackney/jobs/568343040#L515 https://travis-ci.org/benoitc/hackney/jobs/563376913#L514

By the way, I updated the cowboy to version 1.1.2 , and Travis CI fetched the ranch version 1.3.2. All tests passed as a result.

https://travis-ci.org/techno-tanoC/hackney/jobs/571190015#L515

benoitc commented 4 years ago

sorry it took to much tome to handle it. We are now testing only against last versions and then doesn't need that change any more. Thanks for it anyway!