benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

Remove honor_cipher_order SSL option #588

Closed nifoc closed 5 years ago

nifoc commented 5 years ago

Setting honor_cipher_order returns the following error when used with OTP 22.1: {option, server_only, honor_cipher_order}

It seems like older versions simply ignored the option, since even the original PR mentions it being an option for the server.

nifoc commented 5 years ago

All test failures seem to be unrelated.

benoitc commented 5 years ago

Thanks for the patch. I merged #590 that added 22 to the CI but thanks again!