search

benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

Remove setting honor_cipher_order client side #590

Closed vihu closed 5 years ago

vihu commented 5 years ago

This option is not meaningful to set on the client side, it worked prior to the check added in OTP22.1 here: https://github.com/erlang/otp/commit/124da8950c1fe93ef02cb044157e78798bc2360d#diff-79b520311347e34fac9cffbc4ea373f9R1720

benoitc commented 5 years ago

why closing?

vihu commented 5 years ago

588 and #589 seem to be aiming for the same error I noticed today. I suppose OTP22.1 really highlighted this problem.

benoitc commented 5 years ago

noticed it after , yes. I will take care about the issue sometimes today :)