search

benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

URL decode username/password for basic auth parameters #614

Closed mjparrott closed 4 years ago

mjparrott commented 4 years ago

Fixes #595

This also could be fixed here: https://github.com/benoitc/hackney/blob/a3617d8153c638fd6c525aca211e37044f263cbc/src/hackney.erl#L317-L329. Happy to change where the URL encoding/decoding happens if this makes more sense to anyone.

mjparrott commented 4 years ago

By example, you mean another test? The one in the RFC is example that is mentioned in the issue, correct?

benoitc commented 4 years ago

@mjparrott yes exactly :)

benoitc commented 4 years ago

thanks for the patch!