TLS support may be broken on OTP 20.0 / 20.1

benoitc / hackney

simple HTTP client in Erlang

Other

1.34k stars 427 forks source link

TLS support may be broken on OTP 20.0 / 20.1 #636

Closed g-andrade closed 4 years ago

g-andrade commented 4 years ago

As per @okeuday's comment on hackney_ssl.erl, which correlates with a few errors I saw when running the test suites on multiple OTP versions a few days ago but didn't have the chance to investigate.

Creating this issue mostly as a reminder to fix this issue since I'm the one to blame[*], but also for transparency in case anyone else bumps into the same problem.

[]: mea culpa, mea culpa, mea maxima culpa*

g-andrade commented 4 years ago

Will be closed by #637 (if it gets merged.)

okeuday commented 4 years ago

@g-andrade You probably want to use versions from the list https://docs.travis-ci.com/user/languages/erlang/#otprelease-versions for #639 because the Erlang/OTP team has been moving away from release tarballs and using git tags instead (so the "stable" or latest version becomes more of a moving target).