Verify partial_chain with custom ssl_options

benoitc / hackney

simple HTTP client in Erlang

Other

1.34k stars 427 forks source link

Verify partial_chain with custom ssl_options #654

Open spydon opened 4 years ago

spydon commented 4 years ago

If I'm not mistaken it is not possible to use the default partial_chain option when using custom ssl_options in 1.16.0 since partial_chain/1 isn't exported anymore. Or is there a possibility to merge custom ssl options with the default ones?

benoitc commented 4 years ago

check_hostname_opts/1is exported from hackney_ssl. Depending on what you need that maybe enough. I can provbably export the partial_chain callback if needed. What require your custom ssl options for now?

spydon commented 4 years ago

Thanks for the quick reply! I think we mainly use a specific verify_fun and also swap cacerts to cacertfile in some cases. The most useful would be if there was a way to use the hackney SSL defaults opts and then just override a few instead of all of them, is that possible somehow?