Prevent xref warning for unmaintained Erlang/OTP function

benoitc / hackney

simple HTTP client in Erlang

Other

1.34k stars 427 forks source link

Prevent xref warning for unmaintained Erlang/OTP function #662

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

I got an xref analysis error for an unknown function: ssl:seed is not documented in Erlang/OTP's doc.s as "maintained" (it's not there at all), so it's most surely been deprecated a good while ago. I leave it to your judgement to reject the PR (keeping current behavior with no more than a little itch to scratch) or accept it (thus embracing the present and the future).

paulo-ferraz-oliveira commented 3 years ago

Oh, I also took the liberty of adding xref to the CI steps, since now hackney is xref issue -free.

paulo-ferraz-oliveira commented 3 years ago

Is this missing anything you can think of, @benoitc?

benoitc commented 3 years ago

shouls be ok. I will take care of it in tomorrow release :)

benoitc commented 3 years ago

thanks for the patch!