search

benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

Implement GitHub Actions #669

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

Main differences to current CI (Travis):

Closes #668.

benoitc commented 3 years ago

thanks! I will check later this morning. What should I do to enable github actions?

paulo-ferraz-oliveira commented 3 years ago

thanks! I will check later this morning. What should I do to enable github actions?

Two ways I can think of: a. you merge to master - it'll be automatic, but this'll mean that whatever is not working will have to be fixed, either through master or a new pull request b. you go to the Actions' tab, choose Erlang and commit an empty file to master; after that I'll rebase this pull request on top of master and we can make sure that what gets pushed was previously tested

Preferably you'd choose b) 😄

benoitc commented 3 years ago

thanks! I will check later this morning. What should I do to enable github actions?

Two ways I can think of: a. you merge to master - it'll be automatic, but this'll mean that whatever is not working will have to be fixed, either through master or a new pull request b. you go to the Actions' tab, choose Erlang and commit an empty file to master; after that I'll rebase this pull request on top of master and we can make sure that what gets pushed was previously tested

Preferably you'd choose b) 😄

Sorry for the late answer. I will do a proper commit today so we can test it. Thanks !

benoitc commented 3 years ago

Preferably you'd choose b) 😄

done :) I pushed an empty action file. Sorry for the delay... Go ahead anyway

paulo-ferraz-oliveira commented 3 years ago

Rebased and force-pushed. 22.1.8.1 is not available. I'm removing it from the CI to check if the rest is OK.

paulo-ferraz-oliveira commented 3 years ago

I'm removing kerl list installations from CI, since kerl is not available in the container. Is it absolutely required?

paulo-ferraz-oliveira commented 3 years ago

@benoitc: let me know if you want some changes still. I'm using rebar3 from the checkouts since some of the versions bundled with the containers have bugs that would otherwise impact CI for no good reason.

paulo-ferraz-oliveira commented 3 years ago

Oh, you might also want to remove Travis CI from the app, since it's no longer serving any particular purpose.

benoitc commented 3 years ago

I'm removing kerl list installations from CI, since kerl is not available in the container. Is it absolutely required?

not at all :) I will merge the PR , thanks!