search

benoitc / hackney

simple HTTP client in Erlang
Other
1.34k stars 427 forks source link

Avoid parse_trans warning when using hackney as a dependency #676

Closed paulo-ferraz-oliveira closed 3 years ago

paulo-ferraz-oliveira commented 3 years ago

This pull request shows the result of rebar3 do unlock, upgrade as per hackney's rebar.config.

One of the motivations for parse_trans 3.3.1 (and the one for this pull request) is mentioned here: https://github.com/uwiger/parse_trans/pull/41.

Since hackney is a dep. for e.g. https://github.com/inaka/erlang-github, this fix is required to avoid that warning.

@benoitc, a patch release for this would be much appreciated once you find the time for it.

Thanks.

benoitc commented 3 years ago

i was in vacations. I will see if i can cut a release later today. Thanks for the patch!

paulo-ferraz-oliveira commented 3 years ago

No worries. Thanks.

paulo-ferraz-oliveira commented 3 years ago

Benoît, any chance this can get a patch-release? It's blocking another pull request of mine: https://github.com/inaka/erlang-github/pull/189. Thanks much.

benoitc commented 3 years ago

Working on it. It will land this morning.

On Sat 13 Mar 2021 at 00:44, Paulo F. Oliveira @.***> wrote:

Benoît, any chance this can get a patch-release? It's blocking another pull request of mine: inaka/erlang-github#189 https://github.com/inaka/erlang-github/pull/189. Thanks much.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/benoitc/hackney/pull/676#issuecomment-797816610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADRIU26TEPLD3PFI3237TTDKROTANCNFSM4XZL42IA .

-- Sent from my Mobile

benoitc commented 3 years ago

No worries. Thanks.

1.17.1 is out :)