fix(REPLACE): complex type fields. fix(UPDATE/DELETE)(db): id - [merged] #123

Closed benoitdm-oslandia closed 1 year ago

In GitLab by @azarz on Oct 13, 2022, 16:22

_Merges feature/test_datatypereplace -> develop

fix(REPLACE): manage complex type fields.
fix(UPDATE/DELETE)(db): use table id column instead of hardcoded 'id'
fix(UPDATE): no more index nor Location header returned

close #39

In GitLab by @azarz on Oct 13, 2022, 16:22

requested review from @lowzonenose

In GitLab by @azarz on Oct 13, 2022, 16:29

added 1 commit

0d22340e - fix(REPLACE): manage complex type fields. fix(UPDATE/DELETE)(db): use table id...

Compare with previous version

In GitLab by @azarz on Oct 13, 2022, 16:38

added 2 commits

b1318a1d - 1 commit from branch develop
46d22010 - fix(REPLACE): manage complex type fields. fix(UPDATE/DELETE)(db): use table id...

Compare with previous version

In GitLab by @azarz on Oct 14, 2022, 09:57

added 1 commit

58485a07 - fix(REPLACE): manage complex type fields. fix(UPDATE/DELETE)(db): use table id...

Compare with previous version

In GitLab by @azarz on Oct 14, 2022, 10:00

added 1 commit

78662ef7 - fix(REPLACE): complex type fields. fix(UPDATE/DELETE)(db): id

Compare with previous version

In GitLab by @azarz on Oct 14, 2022, 11:34

added 1 commit

128ee049 - fix(UPDATE): no more index nor Location header returned

Compare with previous version

In GitLab by @lowzonenose on Oct 14, 2022, 13:46

Commented on internal/service/db_test/handler_db_put_test.go line 31

Voici comment les tests sont nomenclaturés

In GitLab by @lowzonenose on Oct 14, 2022, 13:46

Commented on internal/service/db_test/handler_db_put_test.go line 31

idem pour les mocks

In GitLab by @azarz on Oct 14, 2022, 13:47

Commented on internal/service/db_test/handler_db_put_test.go line 31

OK, je répare tout ça en faisant mon rebase

In GitLab by @lowzonenose on Oct 14, 2022, 13:48

Commented on internal/service/db_test/handler_db_update_test.go line 74

ces test ne te semblent pas pertinents ?

In GitLab by @lowzonenose on Oct 14, 2022, 13:49

Commented on internal/service/handler.go line 695

On a décidé de ne plus ajouter le Location dans le Header ?

In GitLab by @azarz on Oct 14, 2022, 13:54

Commented on internal/service/db_test/handler_db_put_test.go line 31

changed this line in version 7 of the diff

In GitLab by @azarz on Oct 14, 2022, 13:54

Commented on internal/service/db_test/handler_db_update_test.go line 74

changed this line in version 7 of the diff

In GitLab by @azarz on Oct 14, 2022, 13:54

added 3 commits

944fcc36 - 1 commit from branch develop
ef903765 - fix(REPLACE): complex type fields. fix(UPDATE/DELETE)(db): id
5f30aec0 - fix(UPDATE): no more index nor Location header returned

Compare with previous version

In GitLab by @azarz on Oct 14, 2022, 13:55

Commented on internal/service/handler.go line 695

Ouep vu ce matin : pour UPDATE, REPLACE et DELETE, Location n'a pas lieu d'être

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Location (It only provides a meaning when served with a 3xx (redirection) or 201 (created) status response.)

In GitLab by @azarz on Oct 14, 2022, 13:57

Commented on internal/service/db_test/handler_db_update_test.go line 74

Ouep vu ce matin : pour UPDATE, REPLACE et DELETE, Location n'a pas lieu d'être

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Location (It only provides a meaning when served with a 3xx (redirection) or 201 (created) status response.)

In GitLab by @lowzonenose on Oct 14, 2022, 14:02

resolved all threads

In GitLab by @lowzonenose on Oct 14, 2022, 14:02

approved this merge request

In GitLab by @azarz on Oct 14, 2022, 14:22

approved this merge request

benoitdm-oslandia / pg_featureserv

fix(REPLACE): complex type fields. fix(UPDATE/DELETE)(db): id - [merged] #123