benoitdm-oslandia / pg_featureserv

Apache License 2.0
1 stars 0 forks source link

add missing cache test - [merged] #130

Closed benoitdm-oslandia closed 1 year ago

benoitdm-oslandia commented 1 year ago

_Merges fix/missing_cachetest -> develop

==> 2 bugs found!

ref #50

benoitdm-oslandia commented 1 year ago

requested review from @jmkerloch

benoitdm-oslandia commented 1 year ago

added 30m of time spent

benoitdm-oslandia commented 1 year ago

In GitLab by @azarz on Nov 4, 2022, 15:54

Commented on internal/data/listener.go line 140

Je me demande si le mutex est toujours utile ici vu que @nrevelant l'a implémenté dans la classe Cacher ?

benoitdm-oslandia commented 1 year ago

In GitLab by @azarz on Nov 4, 2022, 15:56

Commented on internal/service/db_test/runner_db_test.go line 96

Déplacer vers la ligne 145 ? (tests associés au listen)

benoitdm-oslandia commented 1 year ago

added 2 commits

Compare with previous version

benoitdm-oslandia commented 1 year ago

In GitLab by @jmkerloch on Nov 4, 2022, 16:04

approved this merge request

benoitdm-oslandia commented 1 year ago

en effet

benoitdm-oslandia commented 1 year ago

ok

benoitdm-oslandia commented 1 year ago

resolved all threads

benoitdm-oslandia commented 1 year ago

changed this line in version 3 of the diff

benoitdm-oslandia commented 1 year ago

changed this line in version 3 of the diff

benoitdm-oslandia commented 1 year ago

added 2 commits

Compare with previous version

benoitdm-oslandia commented 1 year ago

resolved all threads

benoitdm-oslandia commented 1 year ago

@jmkerloch @azarz c'est bon ?

benoitdm-oslandia commented 1 year ago

In GitLab by @azarz on Nov 4, 2022, 16:35

approved this merge request

benoitdm-oslandia commented 1 year ago

approved this merge request