Closed azarz closed 1 year ago
Package | Line Rate | Health |
---|---|---|
github.com/CrunchyData/pg_featureserv/internal/api | 89% | ✔ |
github.com/CrunchyData/pg_featureserv/internal/conf | 53% | ❌ |
github.com/CrunchyData/pg_featureserv/internal/cql | 67% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/data | 63% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/service | 67% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/ui | 82% | ✔ |
github.com/CrunchyData/pg_featureserv | 22% | ❌ |
Summary | 69% (6038 / 8749) | ➖ |
Minimum allowed line rate is 60%
Package | Line Rate | Health |
---|---|---|
github.com/CrunchyData/pg_featureserv/internal/api | 89% | ✔ |
github.com/CrunchyData/pg_featureserv/internal/conf | 54% | ❌ |
github.com/CrunchyData/pg_featureserv/internal/cql | 67% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/data | 63% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/service | 68% | ➖ |
github.com/CrunchyData/pg_featureserv/internal/ui | 82% | ✔ |
github.com/CrunchyData/pg_featureserv | 22% | ❌ |
Summary | 69% (6068 / 8769) | ➖ |
Minimum allowed line rate is 60%
LGTM! Just if you can add a test with projection name like with EPSG:2154 or IGNF:LAMB93... this should do the same job!
This would imply a change in the current API, which currently needs a number in the request, corresponding to the SRID in postGIS. An other issue is that the IGNF: SRSs are not available in postGIS... I tried to find a standard definition of the IGNF:LAMB93 as in http://www.opengis.net/def/crs/EPSG/0/2154, IGNF is not even listed in http://www.opengis.net/def/crs/.
One way to tackle this issue would be to accept proj
strings, but I don't know if this is a good idea...
Ok so no need to go further and we will update the documentation accordingly.
We should also document that for POST, PUT and PATCH, the crs is defined by the Content-Crs
header. I don't know where to specify that in the openApi definition.
We should also document that for POST, PUT and PATCH, the crs is defined by the
Content-Crs
header. I don't know where to specify that in the openApi definition.
Done
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
16 Code Smells
No Coverage information
0.0% Duplication
New review required since I rebased on develop @jmkerloch @benoitdm-oslandia (I didn't change anything)
closes #18 (already implemented, added tests and better error handling) closes #17