Feature/create feature (mock) - [merged]

[benoitdm-oslandia]

_Merges feature/createfeature -> develop

Ref #19

Reste la création effective dans le mock et dans la base

[benoitdm-oslandia]

added 6 commits

• cc3243be...598e0ad0 - 5 commits from branch develop
• a75e4df5 - DRAFT: Add functionality to create new feature in a collection.

Compare with previous version

[benoitdm-oslandia]

marked this merge request as ready

[benoitdm-oslandia]

added 3 commits

• a75e4df5...24d009ac - 2 commits from branch develop
• 4b6e3e56 - DRAFT: Add functionality to create new feature in a collection.

Compare with previous version

[benoitdm-oslandia]

marked this merge request as draft from 4b6e3e56339d3bd405311b0a28a4971e215af356

[benoitdm-oslandia]

In GitLab by @azarz on Aug 30, 2022, 16:36

Commented on internal/service/handler_post_test.go line 40

Ici, ne faudrait-il pas tester plutôt si l'opération Post est possible ?

    equals(t, "postCollectionSchema", path.Post.OperationID, "schema path post present")

pas sûr du tout pour la syntaxe complète...

(https://pkg.go.dev/github.com/getkin/kin-openapi/openapi3?utm_source=godoc#PathItem)

(je suis en train de regarder pour voir comment tester la présence du PUT, si ça se trouve c'est ici que l'on teste le Get et le Post est traité ailleurs, dans ce cas au temps pour moi)

[benoitdm-oslandia]

Ici, ne faudrait-il pas tester plutôt si l'opération Post est possible ?

non en fait ici je vérifie que l'opération pour obtenir le schéma pour faire un create est disponible dans le swagger.

[benoitdm-oslandia]

resolved all threads

[benoitdm-oslandia]

added 3 commits

• cbee1fce - writeCreateItemSchemaJSON: required properties are now inserted in a sorted way
• caac73f0 - Improve error msg by adding info by using existing Error object.
• 5184b3f8 - CreateFeature: add schema validation

Compare with previous version

[benoitdm-oslandia]

added 7 commits

• 5184b3f8...48233ce2 - 2 commits from branch develop
• 99cb4840 - DRAFT: Add functionality to create new feature in a collection.
• 13eb0b50 - writeCreateItemSchemaJSON: required properties are now inserted in a sorted way
• cdf8ee0e - Improve error msg by adding info by using existing Error object.
• 5a43a74d - CreateFeature: add schema validation
• 5dc66c72 - temp commit

Compare with previous version

[benoitdm-oslandia]

added 1 commit

• 7c2e43cb - gitlab-ci: activate linter

Compare with previous version

[benoitdm-oslandia]

added 1 commit

• c2de47a6 - fix error from linter

Compare with previous version

[benoitdm-oslandia]

added 7 commits

• cf277db5 - gitlab-ci: activate linter
• 9ee020b7 - Add functionality to create new feature in a collection.
• 1124b06b - writeCreateItemSchemaJSON: required properties are now inserted in a sorted way
• e9fc0712 - Improve error msg by adding info by using existing Error object.
• c88f67f6 - CreateFeature: add schema validation
• 0be3117b - Add geojson geometry management in catalog
• d118080c - catalog_mock: implements AddTableFeature

Compare with previous version

[benoitdm-oslandia]

added 7 commits

• 2cebe1a5 - 1 commit from branch develop
• 70972f6e - Add functionality to create new feature in a collection.
• bceeddf6 - writeCreateItemSchemaJSON: required properties are now inserted in a sorted way
• 0aec1f4c - Improve error msg by adding info by using existing Error object.
• f29376a0 - CreateFeature: add schema validation
• 8ef13d86 - Add geojson geometry management in catalog
• ddd1a6d2 - catalog_mock: implements AddTableFeature

Compare with previous version

[benoitdm-oslandia]

marked this merge request as ready

[benoitdm-oslandia]

In GitLab by @azarz on Sep 1, 2022, 14:57

approved this merge request

[benoitdm-oslandia]

In GitLab by @nrevelant on Sep 1, 2022, 16:13

Commented on internal/data/catalog_db.go line 51

A quoi correspondent les attributs tableIncludes et tableExcludes ici, à filtrer l'accès aux différentes tables ? Inhiber l'accès aux tables "techniques" pour pivilégier uniquements l'accès aux tables contenant des enregistrements/feature métier ?