search

benoitkugler / go-weasyprint

(WIP) Golang port to weasyprint python html to pdf library
https://pkg.go.dev/github.com/benoitkugler/go-weasyprint
BSD 3-Clause "New" or "Revised" License
23 stars 1 forks source link

Addition of test suite #7

Closed kishaningithub closed 2 weeks ago

kishaningithub commented 4 weeks ago

Would be great of this package has running CI tests in github actions.

benoitkugler commented 4 weeks ago

Sure thing ! Would you like to open a PR to do so ?

kishaningithub commented 3 weeks ago

Sure will do

kishaningithub commented 3 weeks ago

Have created PR https://github.com/benoitkugler/go-weasyprint/pull/8 to address this

When the tests are running i see the below error (screenshot below) can you kindly help out?

image
benoitkugler commented 3 weeks ago

Almost all the tests use a font index, which must be generated at least once. I guess some tests incorrectly assume it has been done. It should be simple enough to fix, I'll look into it when I'm back behind a computer.

benoitkugler commented 2 weeks ago

The last few commits have resolved the issue. Thank you for adding this test suite !