search

benoitsan / BBUncrustifyPlugin-Xcode

Xcode plugin to format source code using ClangFormat or Uncrustify
MIT License
1.19k stars 150 forks source link

Remove builtin uncrustify configuration #98

Closed danydev closed 9 years ago

danydev commented 9 years ago

In the general case I don't want uncrustify to format the code when I'm working on third party projects (when they don't provide an uncrustify config file). For this reason I don't put a fallback uncrustify file in ~/.uncrustify or ~/. The problem is that currently the plugin fallbacks on a uncrustify configuration bundled in the plugin itself, IMO this is rarely what a developer wants. The pull request removes the default uncrustify configuration file that is bundled within the plugin, respecting the user expectation (i.e. no uncrustify on saving when no conf has been provided by the user). Alternatively I could just disable temporarily the plugin, but it doesn't look optimal in my opinion.

benoitsan commented 9 years ago

Thanks Dany. It made sense to remove the default configuration. The PR is merged.