Optimized types - Githubissues

benoitseron / BosonSampling.jl

Boson sampling tools for Julia

MIT License

26 stars 5 forks source link

Optimized types #47

Closed AntoineRestivo closed 2 years ago

AntoineRestivo commented 2 years ago

ToyModel -> OneParameterInterpolation
new UserDefinedGramMatrix
RandomModel -> RandomGramMatrix
distinguishability -> distinguishability_param (could still be changed in the future)
Shorter definition of the input

AntoineRestivo commented 2 years ago

The errors in the current main branch (lying in the example_usage) seem to be the same as the ones present when you run this version. Let's fixe them once the pull_request is done however this version should resolve all the errors in the unit test

AntoineRestivo commented 2 years ago

I guess some of your stuff that appear now in green are some lines that I removed for the first merge and that I added manually after.

AntoineRestivo commented 2 years ago

@benoitseron Ok I'am back on our project! I've corrected all the commented part except one left that I am not sure to understand, could you enlighten me?