search

benoitseron / Permanents.jl

Functions to compute matrix permanents
MIT License
8 stars 3 forks source link

ryser does not support non square matrix #4

Closed AntoineRestivo closed 2 years ago

AntoineRestivo commented 2 years ago

One temporary solution could be to add the good old fast_perm in case the input matrix is not squared

benoitseron commented 2 years ago

I don't think the permanent is defined for non square matrices, where did you need that?

There is of course an equivalent in terms of just sums and products when computing amplitudes but I don't think it has a special name

AntoineRestivo commented 2 years ago

No no I am just saying that the function does not work anymore with the matrix I input in noisy_distribution (line 50) < distributions < BosonSampling.jl, while for an obscure reason naive works fine.

benoitseron commented 2 years ago

you need to change permanent ryser to "ryser" no?

AntoineRestivo commented 2 years ago

No I had already changed it but the problem is fixed!