search

benr77 / obsidian-gitlab-issues

Obsidian plugin to create/update/remove notes based on GitLab issues
MIT License
28 stars 15 forks source link

feat: handle special chars & add project folders #12

Closed pugooo closed 1 year ago

pugooo commented 1 year ago

This closes #8 and is a simple approach regarding #9.

Regarding #8: Colons are removed. All the other special chars are replaced by '-'.
Regarding #9: After issue retrieval it will also fetch related projects. It will then create a folder per project and place issues inside the folder.

benr77 commented 1 year ago

Hello. Thanks for your input! Sorry but I won't merge it like this as it's a mixture of coding standards fixes, a bug fix and a new feature.

Please can you submit separate PRs for

I'm not sure your solution to the project related stuff in #9 actually addresses the problem either - can we flesh this out more in the issue before you submit a PR.

I also think there's a problem with the Windows filename bugfix as you are regexing the issue title which is used in the issue note itself. We only need the filename to be fixed up, so this needs doing here instead:

https://github.com/benr77/obsidian-gitlab-issues/blob/35b3b523b7376ebcb7aa62be03365d8c4d14beae/src/filesystem.ts#L67

Thanks.

pugooo commented 1 year ago

I issued a new PR for #8.
Regarding #9 I agree, that my approach doesn't resolve the whole requirement.
Are you ok, if I open a new issue regarding my simple approach and submit a PR for that, as it already improves the usability. It also shouldn't be a problem to then flesh it out more in the future for #9.