search

benrady / shinatra

A simple web server in 5 lines of bash
811 stars 81 forks source link

Only four lines instead of five #13

Closed frdmn closed 7 years ago

frdmn commented 7 years ago

Is the RESPONSE variable needed? Would save a whole line :P

What do you think?

nir0s commented 7 years ago

According to this logic, you could do it in one line..

frdmn commented 7 years ago

I'm not sure to be honest, removing line breaks (minifying) usually works in an any language. But my PR acutally consolidates one declaration => changes the behaviour of the code, not just trying to save irrelevant characters / bytes.

Just close the PR if you don't agree and don't want to merge this, though :)