benrbray / noteworthy

Markdown editor with bidirectional links and excellent math support, powered by ProseMirror. (In Development!)
https://noteworthy.ink
GNU Affero General Public License v3.0
232 stars 14 forks source link

consider using `prosemirror-autocomplete` instead of `prosemirror-suggest` #44

Closed benrbray closed 1 year ago

benrbray commented 1 year ago

the existing suggestion popup needs a makeover, so I need to decide between:

  1. keep using prosemirror-suggest
  2. switch to prosemirror-autocomplete
  3. build my own solution
rowanc1 commented 1 year ago

If there is something that needs changing over in prosemirror-autocomplete, happy to try and make it happen. It has worked well for us over in Curvenote.

benrbray commented 1 year ago

@rowanc1 Thanks very much for the prosemirror-autocomplete package, it's great! I've decided to switch from prosemirror-suggest to prosemirror-autocomplete, because:

I opened a small PR curvenote/editor#185 to add a cancelOnSpace option, let me know what you think!

rowanc1 commented 1 year ago

So awesome! Glad it is working for you!

I will take a look at the PR soon, thanks for the detailed write up.

benrbray commented 1 year ago

Merged! Code for the autocomplete extension can be found here.

noteworthy-autocomplete