search

benrhughes / todotxt.net

An implementation of todo.txt for Windows using the .NET framework
http://benrhughes.github.io/todotxt.net/
Other
500 stars 123 forks source link

Priority keyboard shortcut loses focus #194

Closed ghost closed 9 years ago

ghost commented 10 years ago

I'm having problems using the keyboard shortcut for changing priority (Alt+Down, Alt+Up). Previously it worked like this: hold Alt, press Down twice -> priority goes from, say, none to (B). Now, it loses focus after the first Down and the cursor jumps to the bottom of the list.

Update: actually, this is only the case for one particular task. Give me some time to come up with the exact conditions for this bug.

benrhughes commented 10 years ago

This is a problem whenever you have tasks with exactly the same body, because the body text is what's used to locate the task in the list.

This causes a few issues, most notably when grouping is enabled and a task is in multiple groups. On 18 Mar 2014 18:30, "sssimon" notifications@github.com wrote:

Update: actually, this is only the case when I have a copy of a task made with the new shortcut (Ctrl+Shift+C).

Reply to this email directly or view it on GitHubhttps://github.com/benrhughes/todotxt.net/issues/194#issuecomment-37905770 .

ghost commented 10 years ago

I can confirm, this todo.txt causes the problem:

exact same task name +project1
exact same task name +project2

It's a small problem, sure. Are there plans to change the method of locating the task in the list? Maybe the file line?

benrhughes commented 10 years ago

"Plans" might be too strong a word, but I have been thinking about it :)

The problem with the grouping example is that they aren't different tasks with the same body, it's actually the same task appearing multiple times. So, using any sort of identifier on the task itself doesn't help. Essentially we need to change the whole way we track selection in the list. I have a couple of ideas but haven't had the time to really try them out yet.

Cheers,

Ben

On Tue, Mar 18, 2014 at 7:36 PM, sssimon notifications@github.com wrote:

I can confirm, this todo.txt causes the problem:

exact same task name +project1 exact same task name +project2

It's a small problem, sure. Are there plans to change the method of locating the task in the list? Maybe the file line?

Reply to this email directly or view it on GitHubhttps://github.com/benrhughes/todotxt.net/issues/194#issuecomment-37909507 .

mjdescy commented 9 years ago

I think version 3.1.0 effectively closes this bug. Task selection in the list isn't perfect (there still isn't a way to differentiate duplicate tasks, for example), but it is a lot better, and the behavior @sssimon describes no longer occurs.