search

benrhughes / todotxt.net

An implementation of todo.txt for Windows using the .NET framework
http://benrhughes.github.io/todotxt.net/
Other
500 stars 123 forks source link

Fix order of ok and cancel buttons #352

Closed flof closed 6 years ago

flof commented 6 years ago

This commit makes the order of the ok and cancel buttons in the settings- and filter-dialog windows standard conform. The ok-button should be left, cancel-button should be right.

benrhughes commented 6 years ago

Thanks for the PR, but I prefer the order as it is.

flof commented 6 years ago

I think, it would make the UI more consitent. Other dialogs, like Set-priority or Set-due-date, have the ok-button on the left side, the settings- and the filter-dialog have the ok-button on the right side. This forces the users to read the button-labels all the time.

shulist commented 5 years ago

In testing 3.3.1 (Beta) this does not seem to be done. The order of the buttons on the Options and the Filters window is [Cancel] is left and [Ok] is right. This needs to be reversed as per PR.

daveliao commented 4 years ago

Confirmed 3.3.1 (Production) still shows "Cancel" on the left, and "OK" on the right...