search

benrhughes / todotxt.net

An implementation of todo.txt for Windows using the .NET framework
http://benrhughes.github.io/todotxt.net/
Other
500 stars 123 forks source link

Intellisense within filter window #66

Closed ghost closed 9 years ago

ghost commented 12 years ago

"Intellisense for projects and contexts" is a great feature. Could it also be made available in the filter window?

kevininspace commented 12 years ago

I've got something working on this. I'll polish it up and add some unit tests.

Note that this requires some refactoring of the Intellisense methods into their own class. This is a Good Thing since it moves us towards an MVVM pattern (removing most/all code in xaml.cs files to their own classes, allowing for better code reuse, separation of business logic and UI, and better unit testing capabilities.)

benrhughes commented 12 years ago

Excellent. I've started a (very early) mvvm refactor in another branch, so your change would be a big help.

This app is one of those quick, no design apps that gets a life of its own, and it was my first wpf app so I had no idea what I was doing. Now I'm doing wpf at work, and the codebase is growing, the lacks of design is starting to bug me :)

On 11/09/2012, at 1:49 AM, kevininspace notifications@github.com wrote:

I've got something working on this. I'll polish it up and add some unit tests.

Note that this requires some refactoring of the Intellisense methods into their own class. This is a Good Thing since it moves us towards an MVVM pattern (removing most/all code in xaml.cs files to their own classes, allowing for better code reuse, separation of business logic and UI, and better unit testing capabilities.)

— Reply to this email directly or view it on GitHubhttps://github.com/benrhughes/todotxt.net/issues/66#issuecomment-8427390.

mjdescy commented 9 years ago

@benrhughes I can take a crack at this in the next month or two. It sounds like you have some ideas about the design pattern. Care to share them?

I know that I have improved the app's design pattern, but it still isn't perfect. If you have any suggestions to reduce the xaml.cs codebase, I could work on them.

benrhughes commented 9 years ago

I didn't so much have an idea as know that I needed to do a big refactor before I attempted it :-) I think the work you've already done to clean things up should make it a lot easier.

On Fri, Dec 12, 2014 at 6:30 AM, Michael Descy notifications@github.com wrote:

@benrhughes https://github.com/benrhughes I can take a crack at this in the next month or two. It sounds like you have some ideas about the design pattern. Care to share them?

I know that I have improved the app's design pattern, but it still isn't perfect. If you have any suggestions to reduce the xaml.cs codebase, I could work on them.

— Reply to this email directly or view it on GitHub https://github.com/benrhughes/todotxt.net/issues/66#issuecomment-66673889 .

mjdescy commented 9 years ago

It looks like are still a couple kinks to work out in this feature. I will fix them while I continue to test dev builds.

mjdescy commented 9 years ago

I just confirmed that the bug I fixed in commit 2cd6e40 was present in version 3.1.0, too. That was my main concern when I commented earlier today. This feature is now working properly as of commit 2cd6e40.