benrr101 / node-taglib-sharp

A node.js port of mono/taglib-sharp
GNU Lesser General Public License v2.1
42 stars 11 forks source link

Change ogg page header granule position property to bytevector #75

Closed benrr101 closed 1 year ago

benrr101 commented 1 year ago

According to OGG spec, the page header's granule position must be monotonically increasing, but doesn't specify if the value is a number or anything. As such, we shouldn't store it as a number and should just represent it as a byte vector. Is this strictly necessary ... well no not really, especially since it increases some complexities by needing to screw around with bigints. But, even if we treated it as a number, it would need to be a bigint anyways. So ... whatever.

benrr101 commented 1 year ago

Also note, this fixes #75