Fix ripple layer for MenuItem header style not respecting RecognizesAccessKey.

benruehl / adonis-ui

Lightweight UI toolkit for WPF applications offering classic but enhanced windows visuals

https://benruehl.github.io/adonis-ui/

MIT License

1.71k stars 143 forks source link

Fix ripple layer for MenuItem header style not respecting RecognizesAccessKey. #60

Closed SirTony closed 4 years ago

SirTony commented 4 years ago

The default style for MenuItem headers without the ripple layer correctly sets RecognizeAccessKey (MenuItem.xaml#L140@5515312), however the ripple layer header template does not (MenuItem.xaml#L88@5515312), resulting in menu items with no children and a keyboard accelerator key displaying a literal underscore on mouse down.

example

benruehl commented 4 years ago

Good find, thanks for fixing it right away!