search

benschwarz / metaquery

A declarative responsive web design syntax. Breakpoints, defined in `<meta>`
MIT License
324 stars 25 forks source link

Avoid dollar sign collision in jQuery version #3

Closed bganotoo closed 12 years ago

bganotoo commented 12 years ago

There is a potential for other libraries to use the dollar sign global. To be safe, it should be passed into your IIFE just like window and document.

benschwarz commented 12 years ago

Great point, I'd totally missed that in my rush to pull together the first jQuery version— One question about your diff though: It changes every line… do you think you could send a commit that only changes the two lines required? Then I'll merge straight away.

Happy to make the commit myself, but you should get attribution for your pickup :-)

benschwarz commented 12 years ago

I made commit cdbb5386c7b9d75c6a75439841a5b5fda8b4b144 in your absence. Thanks !

bganotoo commented 12 years ago

No worries. I’m new to Git and GitHub for Windows appears to be automatically “fixing” the line endings for me. I’ll guess I need to learn how to use the command line tool after all.

Brandon Gano

From: Ben Schwarz [mailto:notifications@github.com] Sent: Saturday, August 11, 2012 6:16 PM To: benschwarz/metaquery Cc: bgano Subject: Re: [metaquery] Avoid dollar sign collision in jQuery version (#3)

I made commit https://github.com/benschwarz/metaquery/commit/cdbb5386c7b9d75c6a75439841a5b5fda8b4b144 cdbb538 in your absence. Thanks !

— Reply to this email directly or view it on GitHub https://github.com/benschwarz/metaquery/pull/3#issuecomment-7671918 . https://github.com/notifications/beacon/e7Jim3LVLme6SMPd_ZTdEOdP3WyF8Bq-ZopEsQg5KjnGAzrOSdYZkRT7x04HpDz7.gif