search

benschwarz / sublime-bower

Install Bower packages from within Sublime
MIT License
226 stars 12 forks source link

Allow user-configurable registry URL (fixes #33) #34

Closed timkendrick closed 10 years ago

timkendrick commented 10 years ago

This allows the user to specify a custom registry URL in any of 3 locations:

Feel free to make changes to suit your coding / documentation style etc.

benschwarz commented 10 years ago

Wow! You really got onto this quick-smart!

The major concern that I have is the wording in the readme… it doesn't seem obvious that there are three ways to use a custom registry… it somewhat looks like all all three configurations need to be made.

… Which leads me on to ask: why not just have the only configuration option to be within the .bowerrc file? That way it can be shared with teammates vs a local configuration that isn't shared at all.

timkendrick commented 10 years ago

Thanks for the quick response!

Good point, especially seeing as the Sublime settings wouldn't even be picked up by the bower install command anyway. I've removed the unnecessary configuration stuff.

I also had a quick look at the .bowerrc spec and it looks like the registry configuration option can optionally take an object with a search property, so I've accounted for this as well.

Let me know if this is all OK to merge, or if I need to do anything else.

benschwarz commented 10 years ago

LGTM! Thanks @timkendrick :whale: