search

benschwarz / sublime-bower

Install Bower packages from within Sublime
MIT License
226 stars 12 forks source link

Uninstall #42

Open franciscolourenco opened 10 years ago

franciscolourenco commented 10 years ago

Left one ugly hack in bower/utils/cli.py in order to be able to handle package dependency conflicts. Suggestions on a better way to handle exceptions in this case?

benschwarz commented 9 years ago

@aristidesfl hmm… I'm not sure how conflicts should really be handled for this. You could prompt for user input, but I almost think that we should defer to the CLI for such an action?

franciscolourenco commented 9 years ago

Even if we want to defer to CLI and notify the user, we still need the hack or something else to be able to distinguish a conflict from a random exception.

Have you tried it out? It's just a confirmation dialog with an Ok Cancel dialog..

benschwarz commented 9 years ago

I haven't given it a run yet, but as far as I can tell, but I think that “OK” or “Cancel” aren't really the answer to the question… ?

franciscolourenco commented 9 years ago

To be more precise it's actually something like this:

  1. User tries to uninstall jquery
  2. Dialog pop's up: Pop up dialog
benschwarz commented 9 years ago

Ah cool @aristidesfl ! Have you tested this in ST2 & 3?

franciscolourenco commented 9 years ago

I just did a few tests in ST2 and it seems to be working as fine as in ST3