Fix latest migration not affecting `GoodJob.migrated?`

bensheldon / good_job

Multithreaded, Postgres-based, Active Job backend for Ruby on Rails.

https://goodjob-demo.herokuapp.com/

MIT License

2.53k stars 190 forks source link

Fix latest migration not affecting `GoodJob.migrated?` #1345

Closed Earlopain closed 2 months ago

Earlopain commented 2 months ago

The test did not catch this because the migration in the generator migration folder is named incorrectly: it will not be the last migration generated and as such the test just checks that the previous migration was handled (which it is).

I also added a test that ensures that future migrations are named correctly: They must have a unique number prefix. This test fails when the renaming is undone since the prefix 10 is used two times.

bensheldon commented 2 months ago

Thanks for catching this! And sorry about the delay; just got back from vacation 🌴