Closed TAGraves closed 2 months ago
GoodJob should be whitespace tolerant. I'm probably missing some strip
's 🤔 Here's where the string gets broken down into a configuration hash:
Where the configuration constant is broken down: https://github.com/bensheldon/good_job/blob/2586313af6637ee3b865f5cb5d08ebbc435c132a/lib/good_job/multi_scheduler.rb#L12-L15
Where the comma-separated list of queues gets broken down: https://github.com/bensheldon/good_job/blob/2586313af6637ee3b865f5cb5d08ebbc435c132a/app/models/good_job/execution.rb#L42-L68
Also, I love how you've set up your queues 😍
Let me make a test case, but I think it needs more strip
ing
Also, I love how you've set up your queues 😍
Unrelated: my one piece of feedback would be not to use the +
-queue ordering. That has performance downsides and you likely want to clear faster-SLO jobs first rather than the slower-SLO ones.
We had the following
queues
config for a worker:We observed that with this configuration,
workload_5m
jobs were never being worked. I removed all the spaces from the above configuration:Then the
workload_5m
jobs started getting picked up. So it seems like the space between the;
and the+workload_5m,
was causing an issue. I don't see it documented anywhere that whitespace is relevant, and indeed the readme even has several examples of whitespace being used in the queue configuration, so I suspect this is a bug.