search

bensheldon / good_job

Multithreaded, Postgres-based, Active Job backend for Ruby on Rails.
https://goodjob-demo.herokuapp.com/
MIT License
2.53k stars 190 forks source link

[BUG] [Dashboard] count isn't following by the filter #1376

Closed hotrungnhan closed 3 weeks ago

hotrungnhan commented 1 month ago

You guy can look at the picture, job count currently is the sum of all queues, intstead of filter by queues manga image

bensheldon commented 4 weeks ago

Thanks for opening the issue. Would you want to try updating the counts to use the appropriately filtered query? Here's where they're calculated:

https://github.com/bensheldon/good_job/blob/ed7bbe33fde7127a85ef1005722a8afa99afe58e/app/filters/good_job/jobs_filter.rb#L10-L20

hotrungnhan commented 4 weeks ago

Thanks for opening the issue. Would you want to try updating the counts to use the appropriately filtered query? Here's where they're calculated:

https://github.com/bensheldon/good_job/blob/ed7bbe33fde7127a85ef1005722a8afa99afe58e/app/filters/good_job/jobs_filter.rb#L10-L20

i've try this weekend.

bensheldon commented 4 weeks ago

Sorry, this is fixed in #1373. I will release shortly.

hotrungnhan commented 3 weeks ago

Really appreciate yours @bensheldon and @SebouChu efforts, you're guy are making a really goods library, can't wait to apply it in my products.

Now we can close this issue.

SebouChu commented 3 weeks ago

@hotrungnhan Haha, thanks, but all goes to @bensheldon, I'm just a small contributor 😄