Redefine Batch#finished_at to mean all callback jobs have finished too; add Batch#jobs_finished_at to allow not deleting batches until all their callback jobs complete by @bensheldon in bensheldon/good_job#1454
Rails 7.2.1 breaks enqueuing without enqueue_after_transaction_commit? method on queue adapter #1477
Merged pull requests:
Fix documentation for 2nd Batch callback parameter: consistently call it context#1476 (martijnversluis)
Redefine Batch#finished_at to mean all callback jobs have finished too; add Batch#jobs_finished_at to allow not deleting batches until all their callback jobs complete #1454 (bensheldon)
#13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. (@koic)
#13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). (@earlopain)
#13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. (@vlad-pisanov)
#13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. (@vlad-pisanov)
RuboCop 1.66
New features
#13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. (@earlopain)
#13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. (@earlopain)
#13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@zopolis4][])
#13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. (@earlopain)
Bug fixes
#13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. (@koic)
#13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. (@koic)
#13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. (@koic)
#13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. (@koic)
#13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. (@koic)
#13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. (@koic)
#13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. (@koic)
#13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. (@koic)
#13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. (@koic)
#13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). (@koic)
#13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@fatkodima][])
#13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. (@koic)
#13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. (@koic)
#13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. (@earlopain)
#13137: Fix an error for Style/ParallelAssignment when using __FILE__. (@earlopain)
#13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. (@earlopain)
#13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. (@vlad-pisanov)
#13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). (@vlad-pisanov)
#13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). (@vlad-pisanov)
#13126: Fix a false positive for Style/Alias when using multiple alias in def. (@koic)
#13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. (@koic)
#13118: Fix a false positive for Style/MapIntoArray when splatting. (@earlopain)
#13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. (@koic)
#13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. (@koic)
#13134: Fix false negative for Lint/Void when using using frozen literals. (@vlad-pisanov)
#13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. (@koic)
#13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. (@earlopain)
#13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. (@earlopain)
#13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. ([@koic][])
#13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). ([@earlopain][])
#13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. ([@vlad-pisanov][])
#13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. ([@vlad-pisanov][])
1.66.0 (2024-08-31)
New features
#13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. ([@earlopain][])
#13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. ([@earlopain][])
#13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@zopolis4][])
#13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. ([@earlopain][])
Bug fixes
#13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@koic][])
#13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@koic][])
#13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@koic][])
#13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@koic][])
#13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@koic][])
#13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@koic][])
#13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@koic][])
#13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@koic][])
#13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@koic][])
#13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@koic][])
#13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@fatkodima][])
#13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@koic][])
#13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@koic][])
#13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. ([@earlopain][])
#13137: Fix an error for Style/ParallelAssignment when using __FILE__. ([@earlopain][])
#13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. ([@earlopain][])
#13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@vlad-pisanov][])
#13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@vlad-pisanov][])
#13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@vlad-pisanov][])
#13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@koic][])
#13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@koic][])
#13118: Fix a false positive for Style/MapIntoArray when splatting. ([@earlopain][])
#13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@koic][])
#13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@koic][])
#13134: Fix false negative for Lint/Void when using using frozen literals. ([@vlad-pisanov][])
#13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@koic][])
#13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. ([@earlopain][])
#13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. ([@earlopain][])
#13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@protocol7][])
Bumps the bundler-all group with 23 updates in the / directory:
10.4.16.010.4.19.01.156.01.162.01.18.31.18.45.0.75.1.04.1.04.3.02.12.02.13.01.5.71.5.85.18.25.19.05.6.05.7.04.23.04.24.01.65.01.66.11.21.11.22.02.25.12.26.13.0.33.0.50.27.00.29.07.1.3.47.1.45.0.05.1.06.4.66.5.01.1.01.1.10.4.140.4.163.13.03.13.13.13.13.13.33.5.13.5.2Updates
autoprefixer-railsfrom 10.4.16.0 to 10.4.19.0Changelog
Sourced from autoprefixer-rails's changelog.
Commits
987430aRelease 10.4.19.05b36bc6build: upgrade dependencies16fe8daUpdate autoprefixer to 10.4.19cf0af28Update documentation on source maps in README.md8cb3b04Add Ruby 3.3 to CI matrixUpdates
aws-sdk-s3from 1.156.0 to 1.162.0Changelog
Sourced from aws-sdk-s3's changelog.
Commits
Updates
bootsnapfrom 1.18.3 to 1.18.4Changelog
Sourced from bootsnap's changelog.
Commits
cae219aRelease 1.18.4407bdefMerge pull request #489 from Shopify/fix-load-error7afa951Fix bootsnap setup in environments without bundlerc5513d9Merge pull request #487 from Uaitt/update-gh-action-versions65691caUpdate GitHub actions versions156b8c9Merge pull request #485 from Uaitt/changelog-typoe76fe38Merge pull request #486 from Uaitt/correct-rubocop-offenses9ec8d70Correct Rubocop offenses47ad134Correct a typo present in the CHANGELOGf627992Add --version flagUpdates
chartkickfrom 5.0.7 to 5.1.0Changelog
Sourced from chartkick's changelog.
Commits
4a328e5Version bump to 5.1.0 [skip ci]aac53ceUpdated license year [skip ci]14ccbf1Updated license year [skip ci]b9dd170Updated Chart.js to 4.4.4e3cdfecImproved code [skip ci]c3b3926Dropped support for Ruby < 3.1Updates
good_jobfrom 4.1.0 to 4.3.0Release notes
Sourced from good_job's releases.
... (truncated)
Changelog
Sourced from good_job's changelog.
... (truncated)
Commits
62af353Release good_job v4.3.09783e3cEnsure before actions run on root route (#1482)4d443b3Don't delete batches until all their callback jobs complete (#1454)5409e2cUpdate dependabot.yml5152a7bHandle gem loading errors inperform_inline(#1486)f294e30Fix documentation for 2nd Batch callback parameter: consistently call it `con...9a78188Release good_job v4.2.12b815caBump fugit from 1.11.0 to 1.11.1 (#1471)d8ea45aBump rexml from 3.3.3 to 3.3.6 (#1473)0e3d094fix strict_loading_by_default in BaseRecord (#1475)Updates
jbuilderfrom 2.12.0 to 2.13.0Release notes
Sourced from jbuilder's releases.
Commits
9aa3dd9Use new version constacf7a46No lock committedd469896Bump version for 2.13.09bcd653Add test binstub99c42bdAdd release binstube18fe2aGive Jbuilder a programmatically accessible version1a18149Use newparams.expectsyntax (#573)5288e8aRemove OpenStruct references from Jbuilder (#567)acf44b8Add missing ':see_other' status code in generated destroy controller method (...0adeb96Suggestion: Return early from collection partial rendering if blank. (#560)Updates
pgfrom 1.5.7 to 1.5.8Changelog
Sourced from pg's changelog.
Commits
cb35e3fUpdate to Postgresql-16.4 and OpenSSL-3.3.2 for Windows binary gems7af75a4Bump VERSION to 1.5.8 and add changelog entryd4c6c61Merge pull request #589 from larskanis/fix-host-dup-on-resetbf7d57fSave connection options for conn.reseta2a3e6dCI: github actions@v4need distinct artifact namesdd060bcMerge pull request #587 from larskanis/github-v47515aacCI: Use latest github actions070b72bRemove unused variable in spec65c5031Improve code documentation60f74ffFix typoUpdates
sentry-railsfrom 5.18.2 to 5.19.0Changelog
Sourced from sentry-rails's changelog.
Commits
43c5cc2release: 5.19.0a09da50Include Sentry meta tag in the layout automatically (#2369)Updates
textacularfrom 5.6.0 to 5.7.0Changelog
Sourced from textacular's changelog.
Commits
89eedb3release 5.7.0ea00b4arelax Active Record dependency7ebd3e1Merge pull request #159 from bensheldon/patch-168c7086Merge pull request #161 from elektronaut/rails-7-20e854f8Add support for TestCase.fixture_pathsf15394cFix migrations task0d23e59Update gem requirements to allow Rails 7.24e1a6f3Defer extending ActiveRecord::Base until Active Record is loadedUpdates
selenium-webdriverfrom 4.23.0 to 4.24.0Release notes
Sourced from selenium-webdriver's releases.
Changelog
Sourced from selenium-webdriver's changelog.
Commits
748ffc9Release 4.24.0 (#14429)e4258ea[ci] Use a tag to figure out what we might want to release (#14378)a93c89bAdd timeout and tests for curb, also added the gem curb that was not part of ...7833dc0[rb] Updating the Gemfile.lock as wellf4a86a4[rb] BUGFIX: Add stamp to nightly build (#14320)5d1b216[rb] Fix firefox pipeline by removing guards (#14277)5761c71[rb] Add test for detached shadow root error type (#14267)0652bfc[rb] Deprecate WebStorage JS methods (#14276)Updates
rubocopfrom 1.65.0 to 1.66.1Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
ba8e7beCut 1.66.12900c91Update Changelog08bed81Fix an error forStyle/IfWithSemicolonc2ae362Don't parse YAML twice5f3481fUserubocop-astSimpleForwardable5e65a39Merge pull request #13185 from vlad-pisanov/vp_map_into_array_2d18b3c9Fix false negatives inStyle/MapIntoArrayautocorrection when using `ensure...3277118[Fix #13182] Tweak the doc forStyle/RedundantInterpolationUnfreeze9a38b11Merge pull request #13179 from Earlopain/node-matcher-directiry-errorfd4f4d7Fix an error forInternalAffairs/NodeMatcherDirectivewhen no second argumentUpdates
rubocop-performancefrom 1.21.1 to 1.22.0Release notes
Sourced from rubocop-performance's releases.
Changelog
Sourced from rubocop-performance's changelog.
Commits
bf5f64fCut 1.22.0d26b441Update Changelog7233005Merge pull request #465 from Earlopain/start-end-safe-navigation767f2c9[Fix #407] MakePerformance/DoubleStartEndWithaware of safe navigationf28d18dMerge pull request #466 from Earlopain/block-given-disable8907a12[FixLooks like these dependencies are updatable in another way, so this is no longer needed.