bensonarafat / super_tooltip

SuperTooltip It is super flexible and allows you to display ToolTips in the overlay of the screen.
https://pub.dev/packages/super_tooltip
MIT License
142 stars 96 forks source link

Added decoration builder #108

Closed Sourav-Sonkar closed 3 months ago

Sourav-Sonkar commented 4 months ago

https://github.com/bensonarafat/super_tooltip/issues/107 Decoration need to have access target property,as if we need to pass a custom shape , then we need get access to the target property.

Suggestion to have a call back method which provides target in the supertooltip

typedef DecorationBuilder = Decoration Function(
  Offset target,
);
bensonarafat commented 3 months ago

Thank @Sourav-Sonkar for your contriubtion Let me check it out.

Sourav-Sonkar commented 3 months ago

@bensonarafat Should i remove the Deprecated tag or remove the decoration parameter to fix the lint??

bensonarafat commented 3 months ago

@Sourav-Sonkar Can't we keep both? And set an assert. So they cant use both as the same time

Sourav-Sonkar commented 3 months ago

@Sourav-Sonkar Can't we keep both? And set an assert. So they cant use both as the same time

@bensonarafat we can keep both ... but i think it would made more sense to keep DecorationBuilder only...as both will be returning decoration only

Sourav-Sonkar commented 3 months ago

@bensonarafat removed decoration parameter

bensonarafat commented 3 months ago

Great @Sourav-Sonkar Could you also add an example readme, on how this can be used? So, this can help others thanks

Sourav-Sonkar commented 3 months ago

@bensonarafat add documentation please check

bensonarafat commented 3 months ago

Great @Sourav-Sonkar I will merge it tomorrow. thanks