Implemented the params from, to, canceled,direction and limit.

bensteUEM / ChurchToolsAPI

Collection of Python files to use the API for ChurchTools

6 stars 4 forks source link

Implemented the params from, to, canceled,direction and limit. #18

Closed kolibri52 closed 1 year ago

kolibri52 commented 1 year ago

This solves Issue #3 and also #2

bensteUEM commented 1 year ago

You didn't happen to write test methods for the new params? I would prefer to have tests before merging into master. Should i write them for my test system?

kolibri52 commented 1 year ago

You didn't happen to write test methods for the new params? I would prefer to have tests before merging into master. Should i write them for my test system?

Yes that would be great. If I would upload a testfunction which is set up for my testenvironment / churchtools-installation it would be mixed up for you. Therefore I've online tested it in my local Main function.

bensteUEM commented 1 year ago

I'll also change it to kwargs and add id param...

bensteUEM commented 1 year ago

Was there a reason why you wrote into session params as opposed to passing params to the get request? I suppose the filters should only apply for one single request and not for all following requests?