file_download(self, file_url: str, target_path: str) - Githubissues

bensteUEM / ChurchToolsAPI

Collection of Python files to use the API for ChurchTools

6 stars 4 forks source link

file_download(self, file_url: str, target_path: str) #5

Closed bensteUEM closed 1 year ago

bensteUEM commented 1 year ago

Implemented in https://forum.songbeamer.de/viewtopic.php?f=1&p=23001&sid=d7f00735d9dccdcc0eb7ba89baa0e489#p23001 by kolibri52

needs merge once code is shared

bensteUEM commented 1 year ago

let's change default path to a non OS specific relative default ...
param would be "path_for_download" to match the style of the other function
file_download_fromUrl -> file_download_from_url (so far the method names are using snake instead of camel case ... should keep the same style but certainly can change to camelCase if changed for all functions

all other changes from ChurchToolsApi.py seem to be a nice addition to the existing code

Obviously the changes to main.py and secrets mustn't be included.