search

bensteUEM / ChurchToolsAPI

Collection of Python files to use the API for ChurchTools
6 stars 4 forks source link

Enhancement for Issue#4 and the CSRF-Token Issue during call of file_upload() #8

Closed kolibri52 closed 1 year ago

kolibri52 commented 1 year ago

As discussed in https://forum.songbeamer.de/viewtopic.php?f=1&t=4346&p=23001#p23001 here you find the code for the function get_song_tags_all(self) in addition to that I included the solution for the CSRF-Token issue.

kolibri52 commented 1 year ago

sorry I made several mistakes - I accidentally uploaded my credentials, which I changed back, and I accidentally added the changes all to the same pull request.

Normally I should create a separate pull request for each issue or what is best for you as the owner?

bensteUEM commented 1 year ago

i would suggest isolating the individual changes and discussing some adjustments in the individual bugs. Would you mind pushing your to the dev_kolibri52 (or issues specific branches) ?

Are you able to cherry pick your commits into individual branches in order to merge them seperately into master?

I would certainly like to merge some of the changes while i would have some suggestions for others ...