search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Enabling karma-coverage support #125

Closed alun closed 6 years ago

alun commented 7 years ago

This PR contains modifications which are adding karma-coverage support for karma runner.

In the end it's possible to measure the coverage, add minimum expectations and generate coverage report on the compiled .cljs files

Also karma-config is changed to have keywords as keys while working with it in clojure.

bensu commented 7 years ago

Thank you for the work! I'm a little swamped at work but I'll review it soon.

miikka commented 6 years ago

In master, there's now support for custom Karma configuration, so in principle you can configure coverage by hand. I think that support for packages would still be useful, but because master has changed so much, this patch needs some rework to be mergeable.

alun commented 6 years ago

@miikka thanks for looking into this, I've rewritten the feature on top of the latest master

alun commented 6 years ago

@miikka thanks, all of your remarks are fixed