search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

adds setTimeout wrapper to resolve issues with phantomjs when testing async code #130

Closed ddellacosta closed 7 years ago

ddellacosta commented 7 years ago

@tank157 and I were puzzling over phantomjs crashing when we added async tests (see "Async Testing" here) and finally figured out that this seems to fix it:

http://stackoverflow.com/a/19144932

Let us know if you want to see a minimal example or otherwise want any other tweaking of this PR. Thanks!

ADDENDUM: note that we've released our fork for now so we could get our builds passing--these may be useful for anyone else encountering the same issue: https://clojars.org/democracyworks/doo https://clojars.org/democracyworks/lein-doo

ddellacosta commented 7 years ago

~Nevermind, looks like this shouldn't be necessary and it's simply something we are not doing properly on our side.~ Er, actually the issue remains. Opening this back up, sorry for the back and forth. Once I'm 100% sure there are no issues related to this will close.