search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Usage via boot-cljs-test broken during changes to add Karma #18

Closed crisptrutski closed 9 years ago

crisptrutski commented 9 years ago

Haven't tried to understand the error yet, or looked at your changes, but have verified that still working after #13 and broken on master.

Here's the stracktrace:

             clojure.lang.ExceptionInfo: java.lang.IllegalArgumentException: No value supplied for key: null
    data
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: No value supplied for key: null
     java.lang.IllegalArgumentException: No value supplied for key: null
                                         ...
                       clojure.core/hash-map            core.clj:  371
                                         ...
                          clojure.core/apply            core.clj:  630
               clojure.java.shell/parse-args           shell.clj:   50
                       clojure.java.shell/sh           shell.clj:  112
                                         ...
                          clojure.core/apply            core.clj:  630
                         doo.core/run-script            core.clj:  150

Am just calling doo like so: (doo.core/run-script :rhino) "/super/long/boot/temp/path.js"

crisptrutski commented 9 years ago

Ah, I see the method signature has changed!

Perhaps bump minor version next time?

Also consider incrementing build numbers vs. incrementing versions-that-will-never-have-stable-release, for the impassioned semver cretins out there :smile:

bensu commented 9 years ago

I'm sorry! I didn't deploy it to clojars since it is still wip. I guess I should start by bumpling the version.

bensu commented 9 years ago

Also, I'm not sure about how to handle that signature, hard to say how much should doo.core/run-script know about compiler options.

bensu commented 9 years ago

01.5-SNAPSHOT on master. The last change to 0.1.5 will have a corresponding stable release.

crisptrutski commented 9 years ago

Awesome thanks!

Perhaps push out 0.1.4 with the pre karma version too? That's tied to my last boot-cljs-test version.

Hadn't thought about run-script needing more compiler options, but will look closer at your changes and think about the ideal API

bensu commented 9 years ago

0.1.4 deployed to clojars from the branch release.1.4. The last commit is your PR.

In the future, I'll work on a feature/version branch, so that master reflects the last deployed artifact.

crisptrutski commented 9 years ago

Much appreciated :ghost: