search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Make sure exit code is zero on unhandled promise rejection in node #182

Open arichiardi opened 6 years ago

arichiardi commented 6 years ago

Hello @bensu and all!

I know this is controversial and I can handle it myself in my side of the code but I was wondering whether it makes sense to adopt the following solution by default for :node targets in case of unhandled promise rejection.

https://medium.com/@dtinth/making-unhandled-promise-rejections-crash-the-node-js-process-ffc27cfcc9dd

Leaving this here for further discussion.

Lambeaux commented 2 years ago

+1, although @arichiardi I think you mean "non-zero", correct?

We got hit by this. Builds were passing in Jenkins despite the tests actually failing.