search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

README: minimum node version required 0.12 #27

Closed nberger closed 9 years ago

nberger commented 9 years ago

Adds the minimum node version required to the README. Even though there is a line in the changelog about this, I think that's not too visible.

I was tempted to suggest 0.11 as the minimum required version, because I tried with 0.11 and the tests from the example project (and also in a project of mine) run just fine. But perhaps there are other reasons as of why 0.12 is the minimum version per the changelog?

bensu commented 9 years ago

Thanks! One of the functions used in the node runner was not present in 0.11, but I might have refactored that code afterwards. In any case, I have some ideas to remove the node runner and lift all the seemingly arbitrary node restrictions.

nberger commented 9 years ago

Cool, good to know! And by the way, thanks for the library :)