search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Add regex support to doo-all-tests #50

Closed arichiardi closed 8 years ago

arichiardi commented 8 years ago

As anticipated, this is the easy change, I have also added the same doc string that you can find in cljs.test. I kept it very simple, forwarding and not checking for now, waiting for new cool ideas that will use strings and not regex. Let me know if everything is ok.

PS.: testing it in my local rep correctly prunes all unwanted namespaces.

bensu commented 8 years ago

Hi @arichiardi, thanks for the work, specially the docstring.

While the second arity (doo-all-tests #"my-namespace") works, the first arity doesn't. Multi-arity macros do not work exactly like functions. If you try (doo-all-tests), it fails with a clojure.lang.ArityException, and it is explained here. Also, notice the syntax quote used by the underlying cljs.test/run-all-test macro. Please fix that, and I'll merge.

arichiardi commented 8 years ago

Oh right I always forget that

arichiardi commented 8 years ago

Done ;)

bensu commented 8 years ago

Thanks!

arichiardi commented 8 years ago

:+1: