Closed danielcompton closed 8 years ago
This looks great! I'll test it tomorrow.
I noticed that the Slimer tests exit 0 even when they fail. However I'm using the NPM wrapper for Slimer so that may be the problem. I tried installing Slimer myself to test it locally but I couldn't get it running. Can you check what happens with the exit code when running Slimer with failing tests?
Unfortunately, that is a known Slimer bug, which we are tracking through #39 . It is already fixed in their master, we are waiting for a release.
Hi!
I'm having some trouble with the ./node_modules/.bin/slimerjs -v
. When I install slimerjs locally from the new package.json
(npm install
) I get the binary under node_modules/slimerjs/bin
instead. How did you install it?
As I understand it, node_modules/slimerjs/bin/slimerjs
should be linked to node_modules/.bin
. See https://docs.npmjs.com/files/folders#executables. I didn't do anything particular to set it up. I'm running npm 3.3.5
but I don't think .bin
is a new npm change.
~/Developer/clojure/doo/example on add-circle
$ls -al node_modules/.bin/slimerjs
lrwxr-xr-x 1 Daniel staff 24 13 Nov 19:04 node_modules/.bin/slimerjs -> ../slimerjs/bin/slimerjs
Is there no .bin/
folder created in your .node_modules
folder?
I reinstalled node_modules
and it worked, now merged in c221991d0212da5a2bc7f0b4cc14526c8e2e5a47
Thanks so much for the work on this!
Circle CI is the easiest CI tool for running browser based tests. They already have Chrome installed and you don't need to mess around with
xvfb
to get it running.This commit adds a few things:
You'll need to signup for Circle to be able to run this. They have a free tier. You can see the results of my tests at https://circleci.com/gh/danielcompton/doo/10#commits. Of note, the tests for library are failing at the moment.
I put all of the stuff related to tests failing in the example project to keep it in one place, but I understand it makes things a little messier.
Fixes #54.