search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Nashorn runner. #58

Closed mikesperber closed 8 years ago

mikesperber commented 8 years ago

Here's the Nashorn runner that grew out of #44. We couldn't get Rhino to work in any satisfactory way.

bensu commented 8 years ago

Hey @mikesperber,

This is great work. I see you chose to use jrunscript instead of jjs. Looking at the docs jrunscript is marked as experimental and depending on the setup, it might also be an interface to Rhino. I tried jjs instead and it works. Is there any particular reason to use jrunscript vs jjs?

Here are the changes to use jjs and I'd rather use that if there are no strong reasons to use jrunscript. Let me know what you think and if the proposed changes work for your setup.

mikesperber commented 8 years ago

jjs is not part of the Mac OS X Java distribution. (I didn't see any docs marking jrunscript experimental.)

mikesperber commented 8 years ago

I correct myself: jjs is somewhere in the bowels of the Mac OS X Java installation, but not on the standard path:

http://stackoverflow.com/questions/15306892/nashorn-in-jdk8-b80

bensu commented 8 years ago

The link I provided earlier, http://docs.oracle.com/javase/7/docs/technotes/tools/share/jrunscript.html marks it experimental and that it "may not be available in future versions". Should we point to that SO question in the docs for the Nashorn installation?

Let me know if it does work with jjs.

mikesperber commented 8 years ago

Sorry for taking sooo long trying this out: Indeed, jjs works. Many thanks!