search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Add support for Chrome Canary #73

Closed danielcompton closed 8 years ago

danielcompton commented 8 years ago

Chrome Canary is launched via the karma-chrome-launcher. To support launching two different browsers via one plugin, I could either add a further special case to js-env->plugin and js-env->browser, or refactor the karma code in light of this new use case. I chose the latter as I think it should be more maintainable and less error prone in the long run.

I could be persuaded the other way to add special cases for Chrome Canary if you preferred that more.

danielcompton commented 8 years ago

I would have liked to add tests for this, but karma-chrome-launcher only supports Chrome, Chrome Canary, and Dartium, and there is no Chrome Canary available for Linux.

bensu commented 8 years ago

Cool, thanks!