search

bensu / doo

doo is a library and lein plugin to run cljs.test on different js environments.
Eclipse Public License 1.0
324 stars 63 forks source link

Fixes Windows support #97

Closed empperi closed 8 years ago

empperi commented 8 years ago

Fixes Windows support of doo. Bug wasn't exactly in doo itself but in phantomjs which incorrectly treats Windows drive letters as protocol definitions. Fix is to use protocol definition with three slashes: file:///

Tested this fix also with https://github.com/crisptrutski/boot-cljs-test (version 0.2.2-SNAPSHOT) which couldn't run my tests without this fix. With it everything works as expected.

empperi commented 8 years ago

From what I can gather the failing tests seem to be caused by slimerjs download from npm timeouting.

bensu commented 8 years ago

Looks good, I'll test it locally and merge it. Thanks!