search

bentatum / better-react-spinkit

A collection of loading indicators for React
http://better-react-spinkit.benjamintatum.com/
ISC License
186 stars 25 forks source link

Update to React 16 and remove prop-types from peer dependency #21

Open gforge opened 6 years ago

gforge commented 6 years ago

I'm getting warnings from yarn as below:

warning "better-react-spinkit@2.0.2" has unmet peer dependency "prop-types@^15.5.8".
warning "better-react-spinkit@2.0.2" has incorrect peer dependency "react@^15.5.4".

Would be nice if the package was updated to React 16

kunokdev commented 6 years ago

Any progress on this so far?

findoo commented 6 years ago

I've made a pull request for this https://github.com/bentatum/better-react-spinkit/pull/24

soorajvnair commented 6 years ago

I'm still getting a warning for prop-types and lodash. screen shot 2018-02-20 at 5 44 13 pm

@bentatum Think it's a yarn issue. as detailed in the issues below https://github.com/yarnpkg/yarn/issues/4743 https://github.com/yarnpkg/yarn/issues/4969

If i try with NPM all is well.