bentatum / better-react-spinkit

A collection of loading indicators for React
http://better-react-spinkit.benjamintatum.com/
ISC License
186 stars 25 forks source link

Depend only on required lodash modules: range, memoize #22

Open juhamust opened 6 years ago

juhamust commented 6 years ago

Currently, better-react-spinkit requires whole lodash which increases the size of the bundle unnecessarily. Instead, use specific modules: lodash.memoize and lodash.range

https://github.com/bentatum/better-react-spinkit/search?utf8=%E2%9C%93&q=lodash&type=

andoq commented 6 years ago

Just a note on this if ever approved, but it would be super nice to not also require the latest and strict version of each module. I would guess the requirements for this package are much looser, perhaps (^4.0.0), or something like that.

AndyOGo commented 5 years ago

I face this issue right now. Bloats up my bundle by 1M 😱

abdullahtariq1171 commented 4 years ago

Thinking of releasing my own version of this package with this issue resolved with name much-better-react-spinkit.

3 reacts and I'll do it.